search

balena-io-modules / docker-qemu-transpose

Alter a Dockerfile to allow emulated builds without binfmt
Apache License 2.0
3 stars 0 forks source link

Use prettier and husky for code formatting #9

Closed CameronDiver closed 7 years ago

CameronDiver commented 7 years ago

Add prettier to be ran on precommit, with predefined configuration. Runs on src and typings directory.

Also fixed compiling of typings with newest TS.

Change-type: minor Signed-off-by: Cameron Diver cameron@resin.io

CameronDiver commented 7 years ago

@flesler

  1. Fair point, I like it :)
  2. Yeah maybe that would have been better, but if I'd added it to the precommit and then committed, it would have changed the code anyway. I'm not overly bothered for this repo, but next time :+1:
  3. Yup
  4. This is fairly quick tbh, less than a second. Plus I'm the only person to have ever done a commit :p but perhaps it's worth looking into, I think I'm going to leave it as-is for now.
flesler commented 7 years ago

@CameronDiver you can skip by using git commit .... --no-verify FYI. No need to act on this

CameronDiver commented 7 years ago

Huh, TIL, thanks man.