balena-io-modules / drivelist

List all connected drives in your computer, in all major operating systems
Apache License 2.0
239 stars 90 forks source link

Prebuilds failing on windows #340

Closed lefuturiste closed 5 years ago

lefuturiste commented 5 years ago

Hi! I got a problem, I can't build the latest version of drivelist on Windows.

Environment:

Cmd output: https://gist.githubusercontent.com/StoneSet/483686745455480bbf7a29e9900cf506/raw/9570681645bc8b789a01043a1be788c0cac3e62d/errors%2520install

Detailled log: https://gist.githubusercontent.com/StoneSet/2e3becb3135531eb84c0534eb0faeef4/raw/e61aa8eebc05a4f65f51642aea44bc38494fc76a/qdsqsd.txt

StoneSet commented 5 years ago

Hello, I'm working on the same project, we succeeded to build drivelist.

Now we have this error:

Uncaught (in promise) Error: A dynamic link library (DLL) initialization routine failed.
\\?\C:\Users\valen\Documents\GitHub\RetroBox\desktop\node_modules\drivelist\build\Release\drivelist.node
    at process.module.(anonymous function) [as dlopen] (ELECTRON_ASAR.js:166:20)
    at Object.Module._extensions..node (module.js:671:18)
    at Object.module.(anonymous function) [as .node] (ELECTRON_ASAR.js:166:20)
    at Module.load (module.js:561:32)
    at tryModuleLoad (module.js:504:12)
    at Function.Module._load (module.js:496:3)
    at Module.require (module.js:586:17)
    at require (internal/module.js:11:18)
    at bindings (C:\Users\valen\Documents\GitHub\RetroBox\desktop\node_modules\bindings\bindings.js:112:48)
    at Promise (C:\Users\valen\Documents\GitHub\RetroBox\desktop\node_modules\drivelist\js\index.js:52:17)
    at new Promise (<anonymous>)
    at Object.<anonymous> (C:\Users\valen\Documents\GitHub\RetroBox\desktop\node_modules\drivelist\js\index.js:51:20)
    at Generator.next (<anonymous>)
    at C:\Users\valen\Documents\GitHub\RetroBox\desktop\node_modules\drivelist\js\index.js:22:71
    at new Promise (<anonymous>)
at __awaiter (C:\Users\valen\Documents\GitHub\RetroBox\desktop\node_modules\drivelist\js\index.js:18:12)

https://gist.github.com/StoneSet/50e08c9041ff0c65cf0a3358972f63cb

Regards Environment: (same)

Windows 10 x64 (Surface Pro 3)
VS Enterprise 2015 with all components
python 2.7
npm v6.4.1
node v10.15.0
StoneSet commented 5 years ago

FIX : https://github.com/electron/electron/blob/v0.37.2/docs/tutorial/using-native-node-modules.md#using-native-node-modules

Regards

lefuturiste commented 5 years ago

FIX : https://github.com/electron/electron/blob/v0.37.2/docs/tutorial/using-native-node-modules.md#using-native-node-modules

Regards

We just rebuild the module with the electron context and it's a success. Contact us if you have the same issue and we will be happy to answer.

lurch commented 5 years ago

We just rebuild the module with the electron context and it's a success.

Ahh, so similar to #269 then :wink: