search

balena-io-modules / drivelist

List all connected drives in your computer, in all major operating systems
Apache License 2.0
239 stars 90 forks source link

Make drivelist content aware #376

Closed warpdesign closed 3 years ago

warpdesign commented 3 years ago

Make drivelist content aware, see: https://github.com/electron/electron/issues/18397

Without this, the following warning is displayed when using Electron 8+:

(node:82420) Electron: Loading non-context-aware native module in renderer: '/Users/foo/repos/app/node_modules/drivelist/build/Release/drivelist.node'.

fixes #373

lurch commented 3 years ago

I guess you meant "context aware" rather than "content aware" ?

warpdesign commented 3 years ago

I guess you meant "context aware" rather than "content aware" ?

Yes, that's what I meant.

zvin commented 3 years ago

Replaced with #378 , thanks for the PR @warpdesign