Pass strings between methods as std::string instead of char * - Githubissues

balena-io-modules / drivelist

List all connected drives in your computer, in all major operating systems

Apache License 2.0

239 stars 90 forks source link

Pass strings between methods as std::string instead of char * #387

Closed zvin closed 3 years ago

zvin commented 3 years ago

Fixes "basic_string::_M_construct null not valid" exception aborting program, because WCharToUtf8() returned NULL in some cases, and NULL was being fed to string constructor.
Fixes memory leak because memory allocated with calloc() in WCharToUtf8() was not being freed anywhere
Fixes undefined behavior because GetEnumeratorName() returns pointer to stack memory, that goes outside of scope while pointer still is being used.

Closes #381 Closes #382

Change-type: patch

zvin commented 3 years ago

@balena-ci I self-certify!