search

balena-io-modules / drivelist

List all connected drives in your computer, in all major operating systems
Apache License 2.0
238 stars 90 forks source link

⨯ cannot execute cause=exit status 1 out=$ prebuild-install --runtime napi || node-gyp rebuild #420

Open rlwoodjr opened 1 year ago

rlwoodjr commented 1 year ago

building is giving me the error below. Is there a fix for this?

Environment: Windows 10 Node.js v16.19.0

Same build file worked less than 2 weeks ago.

• build native dependency from sources name=drivelist version=11.0.4 platform=win32 arch=ia32 napi= reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information) error=prebuild-install info begin Prebuild-install version 7.1.1 prebuild-install warn install prebuilt binaries enforced with --force! prebuild-install warn install prebuilt binaries may be out of date! prebuild-install info looking for local prebuild @ prebuilds\drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz prebuild-install info looking for cached prebuild @ C:\Users\runneradmin\AppData\Roaming\npm-cache_prebuilds\dea1a4-drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz prebuild-install http request GET https://github.com/balena-io-modules/drivelist/releases/download/v11.0.4/drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz prebuild-install http 404 https://github.com/balena-io-modules/drivelist/releases/download/v11.0.4/drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz prebuild-install warn install No prebuilt binaries found (target=8 runtime=napi arch=ia32 libc= platform=win32)

• rebuilding native dependency name=@serialport/bindings version=9.2.8 • rebuilding native dependency name=@serialport/bindings-cpp version=10.8.0 • rebuilding native dependency name=drivelist version=11.0.4 ⨯ cannot execute cause=exit status 1 out=$ prebuild-install --runtime napi || node-gyp rebuild

rlwoodjr commented 1 year ago

Also, ubuntu-latest and macos-latest build fine.

Only windows-2019 fails. I tried windows-2022, still failed.

rlwoodjr commented 1 year ago

Here is the Github text. Any help would be appreciated.

Run actions/setup-node@v1
C:\hostedtoolcache\windows\node\16.0.0\x64\node.exe --version
v16.0.0
C:\Windows\system32\cmd.exe /D /S /C "C:\hostedtoolcache\windows\node\16.0.0\x64\npm.cmd --version"
7.10.0
0s
2m 24s
Run samuelmeuli/action-electron-builder@v1.6.0
  with:
    github_token: ***
    mac_certs: ***
    mac_certs_password: ***
    args: -p always
    release: false
    package_root: .
    build_script_name: build
    skip_build: false
    use_vue_cli: false
    max_attempts: 1
  env:
    API_KEY_ID: ***
    API_KEY_ISSUER_ID: ***

Will run Yarn commands in directory "."

Installing dependencies using Yarn…
yarn install v1.22.19
info No lockfile found.
[1/4] Resolving packages...
warning directory-tree@2.4.0: Breaking change, bumped to 3.0.0
warning electron-builder-notarize > electron-notarize@1.2.2: Please use @electron/notarize moving forward.  There is no API change, just a package name change
warning formidable@1.2.6: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
warning multer@1.4.4: Multer 1.x is affected by CVE-2022-24434. This is fixed in v1.4.4-lts.1 which drops support for versions of Node.js before 6. Please upgrade to at least Node.js 6 and version 1.4.4-lts.1 of Multer. If you need support for older versions of Node.js, we are open to accepting patches that would fix the CVE on the main 1.x release line, whilst maintaining compatibility with Node.js 0.10.
warning node-gyp > make-fetch-happen > cacache > @npmcli/move-file@2.0.1: This functionality has been moved to @npmcli/fs
warning socket.io > debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
warning socket.io > engine.io > debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
warning socket.io > socket.io-parser > debug@4.1.1: Debug versions >=3.2.0 <3.2.7 || >=4 <4.3.1 have a low-severity ReDos regression when used in a Node.js environment. It is recommended you upgrade to 3.2.7 or 4.3.1. (https://github.com/visionmedia/debug/issues/797)
warning electron-builder > app-builder-lib > electron-osx-sign@0.6.0: Please use @electron/osx-sign moving forward. Be aware the API is slightly different
warning electron-builder > app-builder-lib > @electron/universal > asar@3.2.0: Please use @electron/asar moving forward.  There is no API change, just a package name change
warning electron-rebuild@3.2.9: Please use @electron/rebuild moving forward.  There is no API change, just a package name change
[2/4] Fetching packages...
[3/4] Linking dependencies...
warning " > jscs-loader@0.3.0" has unmet peer dependency "jscs@^3.0.3".
[4/4] Building fresh packages...
success Saved lockfile.
Done in 78.73s.

Running the build script…

Building the Electron app…
yarn run v1.22.19
$ D:\a\Basic-SENDER\Basic-SENDER\node_modules\.bin\electron-builder --windows -p always
  • electron-builder  version=23.6.0 os=10.0.17763
  • loaded configuration  file=package.json ("build" field)
  • electron-rebuild not required if you use electron-builder, please consider to remove excess dependency from devDependencies

To ensure your native dependencies are always matched electron version, simply add script `"postinstall": "electron-builder install-app-deps" to your `package.json`
  • rebuilding native dependencies  dependencies=@serialport/bindings@9.2.8, @serialport/bindings-cpp@10.8.0, drivelist@11.0.4 platform=win32 arch=x64
  • install prebuilt binary  name=@serialport/bindings version=9.2.8 platform=win32 arch=x64 napi=
  • build native dependency from sources  name=@serialport/bindings
                                          version=9.2.8
                                          platform=win32
                                          arch=x64
                                          napi=
                                          reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information)
                                          error=prebuild-install info begin Prebuild-install version 7.1.1
    prebuild-install warn install prebuilt binaries enforced with --force!
    prebuild-install warn install prebuilt binaries may be out of date!
    prebuild-install info looking for local prebuild @ prebuilds\bindings-v9.2.8-electron-v106-win32-x64.tar.gz
    prebuild-install info looking for cached prebuild @ C:\Users\runneradmin\AppData\Roaming\npm-cache\_prebuilds\07878c-bindings-v9.2.8-electron-v106-win32-x64.tar.gz
    prebuild-install http request GET https://github.com/serialport/node-serialport/releases/download/@serialport/bindings@9.2.8/bindings-v9.2.8-electron-v106-win32-x64.tar.gz
    prebuild-install http 404 https://github.com/serialport/node-serialport/releases/download/@serialport/bindings@9.2.8/bindings-v9.2.8-electron-v106-win32-x64.tar.gz
    prebuild-install warn install No prebuilt binaries found (target=19.1.9 runtime=electron arch=x64 libc= platform=win32)

  • install prebuilt binary  name=drivelist version=11.0.4 platform=win32 arch=x64 napi= 
  • build native dependency from sources  name=drivelist
                                          version=11.0.4
                                          platform=win32
                                          arch=x64
                                          napi= 
                                          reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information)
                                          error=prebuild-install info begin Prebuild-install version 7.1.1
    prebuild-install warn install prebuilt binaries enforced with --force!
    prebuild-install warn install prebuilt binaries may be out of date!
    prebuild-install info looking for local prebuild @ prebuilds\drivelist-v11.0.4-napi-v8-win32-x64.tar.gz
    prebuild-install info looking for cached prebuild @ C:\Users\runneradmin\AppData\Roaming\npm-cache\_prebuilds\[5](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:3:6)87c[6](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:3:7)f-drivelist-v11.0.4-napi-v8-win32-x64.tar.gz
    prebuild-install http request GET https://github.com/balena-io-modules/drivelist/releases/download/v11.0.4/drivelist-v11.0.4-napi-v8-win32-x64.tar.gz
    prebuild-install http 404 https://github.com/balena-io-modules/drivelist/releases/download/v11.0.4/drivelist-v11.0.4-napi-v8-win32-x64.tar.gz
    prebuild-install warn install No prebuilt binaries found (target=8 runtime=napi arch=x64 libc= platform=win32)

  • rebuilding native dependency  name=@serialport/bindings version=9.2.8
  • rebuilding native dependency  name=@serialport/bindings-cpp version=10.8.0
  • rebuilding native dependency  name=drivelist version=11.0.4
  • packaging       platform=win32 arch=x64 electron=19.1.9 appOutDir=dist\win-unpacked
  • downloading     url=https://github.com/electron/electron/releases/download/v19.1.9/electron-v19.1.9-win32-x64.zip size=88 MB parts=4
  • downloaded      url=https://github.com/electron/electron/releases/download/v19.1.9/electron-v19.1.9-win32-x64.zip duration=1.399s
  • downloading     url=https://github.com/electron-userland/electron-builder-binaries/releases/download/winCodeSign-2.6.0/winCodeSign-2.6.0.[7](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:3:8)z size=5.6 MB parts=1
  • downloaded      url=https://github.com/electron-userland/electron-builder-binaries/releases/download/winCodeSign-2.6.0/winCodeSign-2.6.0.7z duration=[8](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:3:9)30ms
  • rebuilding native dependencies  dependencies=@serialport/bindings@9.2.8, @serialport/bindings-cpp@[1](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:1)0.8.0, drivelist@11.0.4 platform=win3[2](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:2) arch=ia[3](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:3)2
  • install prebuilt binary  name=@serialport/bindings version=9.2.8 platform=win32 arch=ia32 napi=
  • build native dependency from sources  name=@serialport/bindings
                                          version=9.2.8
                                          platform=win32
                                          arch=ia32
                                          napi=
                                          reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information)
                                          error=prebuild-install info begin Prebuild-install version 7.1.1
    prebuild-install warn install prebuilt binaries enforced with --force!
    prebuild-install warn install prebuilt binaries may be out of date!
    prebuild-install info looking for local prebuild @ prebuilds\bindings-v9.2.8-electron-v106-win32-ia32.tar.gz
    prebuild-install info looking for cached prebuild @ C:\Users\runneradmin\AppData\Roaming\npm-cache\_prebuilds\913a[4](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:4)f-bindings-v9.2.8-electron-v106-win32-ia32.tar.gz
    prebuild-install http request GET https://github.com/serialport/node-serialport/releases/download/@serialport/bindings@9.2.8/bindings-v9.2.8-electron-v106-win32-ia32.tar.gz
    prebuild-install http 404 https://github.com/serialport/node-serialport/releases/download/@serialport/bindings@9.2.8/bindings-v9.2.8-electron-v106-win32-ia32.tar.gz
    prebuild-install warn install No prebuilt binaries found (target=19.1.9 runtime=electron arch=ia32 libc= platform=win32)

  • install prebuilt binary  name=drivelist version=11.0.4 platform=win32 arch=ia32 napi= 
  • build native dependency from sources  name=drivelist
                                          version=11.0.4
                                          platform=win32
                                          arch=ia32
                                          napi= 
                                          reason=prebuild-install failed with error (run with env DEBUG=electron-builder to get more information)
                                          error=prebuild-install info begin Prebuild-install version 7.1.1
    prebuild-install warn install prebuilt binaries enforced with --force!
    prebuild-install warn install prebuilt binaries may be out of date!
    prebuild-install info looking for local prebuild @ prebuilds\drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz
    prebuild-install info looking for cached prebuild @ C:\Users\runneradmin\AppData\Roaming\npm-cache\_prebuilds\dea1a4-drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz
    prebuild-install http request GET https://github.com/balena-io-modules/drivelist/releases/download/v11.0.4/drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz
    prebuild-install http 404 https://github.com/balena-io-modules/drivelist/releases/download/v11.0.4/drivelist-v11.0.4-napi-v8-win32-ia32.tar.gz
    prebuild-install warn install No prebuilt binaries found (target=8 runtime=napi arch=ia32 libc= platform=win32)

  • rebuilding native dependency  name=@serialport/bindings version=9.2.8
  • rebuilding native dependency  name=@serialport/bindings-cpp version=10.8.0
  • rebuilding native dependency  name=drivelist version=11.0.4
  ⨯ cannot execute  cause=exit status 1
                    out=$ prebuild-install --runtime napi || node-gyp rebuild

    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist>if not defined npm_config_node_gyp (node "C:\hostedtoolcache\windows\node\16.0.0\x64\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild ) 
    Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
      nothing.c
      win_delay_load_hook.cc
      nothing.vcxproj -> D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\Release\\nothing.lib
      drivelist.cpp
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\src\drivelist.cpp([5](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:5)1,[6](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:6)): error C2666: 'Napi::CallbackInfo::operator []': 2 overloads have similar conversions [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\node-addon-api\napi-inl.h(34[7](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:7)7,34): message : could be 'const Napi::Value Napi::CallbackInfo::operator [](size_t) const' [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\src\drivelist.cpp(51,6): message : or       'built-in C++ operator[(napi_callback_info, int)' [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\src\drivelist.cpp(51,6): message : while trying to match the argument list '(const Napi::CallbackInfo, int)' [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\src\drivelist.cpp(57,35): error C2666: 'Napi::CallbackInfo::operator []': 2 overloads have similar conversions [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\node-addon-api\napi-inl.h(3477,34): message : could be 'const Napi::Value Napi::CallbackInfo::operator [](size_t) const' [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\src\drivelist.cpp(57,35): message : or       'built-in C++ operator[(napi_callback_info, int)' [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\src\drivelist.cpp(57,35): message : while trying to match the argument list '(const Napi::CallbackInfo, int)' [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\src\drivelist.cpp(57,56): error C2059: syntax error: ')' [D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist\build\drivelist.vcxproj]
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

                    errorOut=prebuild-install warn This package does not support N-API version 19.1.9
    prebuild-install warn install No prebuilt binaries found (target=19.1.9 runtime=napi arch=ia32 libc= platform=win32)
    gyp info it worked if it ends with ok
    gyp info using node-gyp@7.1.2
    gyp info using node@16.0.0 | win32 | x64
    gyp info find Python using Python version 3.7.9 found at "C:\hostedtoolcache\windows\Python\3.7.9\x64\python3.exe"
    gyp info find VS using VS2019 (16.11.33214.272) found at:
    gyp info find VS "C:\Program Files (x[8](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:8)6)\Microsoft Visual Studio\201[9](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:9)\Enterprise"
    gyp info find VS run with --verbose for detailed information
    (node:5604) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future the property will be read-only.
    (Use `node --trace-deprecation ...` to show where the warning was created)
    gyp info spawn C:\hostedtoolcache\windows\Python\3.7.9\x64\python3.exe
    gyp info spawn args [
    gyp info spawn args   'C:\\hostedtoolcache\\windows\\node\\16.0.0\\x64\\node_modules\\npm\\node_modules\\node-gyp\\gyp\\gyp_main.py',
    gyp info spawn args   'binding.gyp',
    gyp info spawn args   '-f',
    gyp info spawn args   'msvs',
    gyp info spawn args   '-I',
    gyp info spawn args   'D:\\a\\Basic-SENDER\\Basic-SENDER\\node_modules\\drivelist\\build\\config.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   'C:\\hostedtoolcache\\windows\\node\\16.0.0\\x64\\node_modules\\npm\\node_modules\\node-gyp\\addon.gypi',
    gyp info spawn args   '-I',
    gyp info spawn args   'C:\\Users\\runneradmin\\.electron-gyp\\19.1.9\\include\\node\\common.gypi',
    gyp info spawn args   '-Dlibrary=shared_library',
    gyp info spawn args   '-Dvisibility=default',
    gyp info spawn args   '-Dnode_root_dir=C:\\Users\\runneradmin\\.electron-gyp\\19.1.9',
    gyp info spawn args   '-Dnode_gyp_dir=C:\\hostedtoolcache\\windows\\node\\16.0.0\\x64\\node_modules\\npm\\node_modules\\node-gyp',
    gyp info spawn args   '-Dnode_lib_file=C:\\\\Users\\\\runneradmin\\\\.electron-gyp\\\\19.1.9\\\\<(target_arch)\\\\node.lib',
    gyp info spawn args   '-Dmodule_root_dir=D:\\a\\Basic-SENDER\\Basic-SENDER\\node_modules\\drivelist',
    gyp info spawn args   '-Dnode_engine=v8',
    gyp info spawn args   '--depth=.',
    gyp info spawn args   '--no-parallel',
    gyp info spawn args   '--generator-output',
    gyp info spawn args   'D:\\a\\Basic-SENDER\\Basic-SENDER\\node_modules\\drivelist\\build',
    gyp info spawn args   '-Goutput_dir=.'
    gyp info spawn args ]
    gyp info spawn C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe
    gyp info spawn args [
    gyp info spawn args   'build/binding.sln',
    gyp info spawn args   '/clp:Verbosity=minimal',
    gyp info spawn args   '/nologo',
    gyp info spawn args   '/p:Configuration=Release;Platform=Win32'
    gyp info spawn args ]
    gyp ERR! build error 
    gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe` failed with exit code: 1
    gyp ERR! stack     at ChildProcess.onExit (C:\hostedtoolcache\windows\node\16.0.0\x64\node_modules\npm\node_modules\node-gyp\lib\build.js:194:23)
    gyp ERR! stack     at ChildProcess.emit (node:events:365:28)
    gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12)
    gyp ERR! System Windows_NT [10](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:10).0.17763
    gyp ERR! command "C:\\hostedtoolcache\\windows\\node\\16.0.0\\x64\\node.exe" "C:\\hostedtoolcache\\windows\\node\\16.0.0\\x64\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
    gyp ERR! cwd D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist
    gyp ERR! node -v v16.0.0
    gyp ERR! node-gyp -v v7.1.2
    gyp ERR! not ok 
    error Command failed with exit code 1.

                    command='C:\hostedtoolcache\windows\node\16.0.0\x64\node.exe' 'C:\npm\prefix\node_modules\yarn\bin\yarn.js' run install
                    workingDir=D:\a\Basic-SENDER\Basic-SENDER\node_modules\drivelist
error Command failed with exit code 1.
D:\a\_actions\samuelmeuli\action-electron-builder\v1.6.0\index.js:144
                throw err;
                ^

Error: Command failed: yarn run electron-builder --windows  -p always
    at checkExecSyncError (child_process.js:635:[11](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:11))
    at execSync (child_process.js:671:15)
    at run (D:\a\_actions\samuelmeuli\action-electron-builder\v1.6.0\index.js:21:27)
    at runAction (D:\a\_actions\samuelmeuli\action-electron-builder\v1.6.0\index.js:132:4)
    at Object.<anonymous> (D:\a\_actions\samuelmeuli\action-electron-builder\v1.6.0\index.js:150:1)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:[12](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:12)) {
  status: 1,
  signal: null,
  output: [ null, null, null ],
  pid: 68[40](https://github.com/rlwoodjr/Basic-SENDER/actions/runs/3991869680/jobs/6847141879#step:5:41),
  stdout: null,
  stderr: null
}
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
petervanderwalt commented 1 year ago

Running into it with our's too. Github Actions with windows-2019 and windows-latest both bonk out with drivelist. Lately the unstability / nodejs version issues are making us look for alternatives to drivelist. @rlwoodjr - i'll tag you if we find a different solution.

rlwoodjr commented 1 year ago

Thanks, I have been building local for Windws and adding it to the release manually.

lurch commented 1 year ago

FWIW Raspberry Pi Imager also uses this drivelist module, but it only uses the C++ parts and doesn't use any of the nodejs parts.

petervanderwalt commented 1 year ago

@jviotti @jhermsmeier @zwhitchcox Sample run https://github.com/OpenBuilds/OpenBuilds-CONTROL/actions/runs/4116312855/jobs/7106202908 - nothing else changed - so either an issue with drivelist or (less likely) github actions images

  D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist>if not defined npm_config_node_gyp (node "C:\hostedtoolcache\windows\node\16.19.0\x64\node_modules\npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild )  else (node "" rebuild ) 
    Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
      nothing.c
      win_delay_load_hook.cc
      nothing.vcxproj -> D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\Release\\nothing.lib
      drivelist.cpp
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\src\drivelist.cpp(51,6): error C2666: 'Napi::CallbackInfo::operator []': 2 overloads have similar conversions [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\node-addon-api\napi-inl.h(3477,34): message : could be 'const Napi::Value Napi::CallbackInfo::operator [](size_t) const' [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\src\drivelist.cpp(51,6): message : or       'built-in C++ operator[(napi_callback_info, int)' [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\src\drivelist.cpp(51,6): message : while trying to match the argument list '(const Napi::CallbackInfo, int)' [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\src\drivelist.cpp(57,35): error C2666: 'Napi::CallbackInfo::operator []': 2 overloads have similar conversions [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\node-addon-api\napi-inl.h(3477,34): message : could be 'const Napi::Value Napi::CallbackInfo::operator [](size_t) const' [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\src\drivelist.cpp(57,35): message : or       'built-in C++ operator[(napi_callback_info, int)' [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\src\drivelist.cpp(57,35): message : while trying to match the argument list '(const Napi::CallbackInfo, int)' [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\src\drivelist.cpp(57,56): error C2059: syntax error: ')' [D:\a\OpenBuilds-CONTROL\OpenBuilds-CONTROL\node_modules\drivelist\build\drivelist.vcxproj]
    info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
petervanderwalt commented 1 year ago

Yesterday I tested rolling back to drivelist 9.2.4 (which needs Node 14, so also rolled back to 14 in build yaml) Has a successful build https://github.com/OpenBuilds/OpenBuilds-CONTROL/actions/runs/4138523785/jobs/7155029195

Drivelist v11 gyp rebuild is just too unstable it seems - but we would love to be on Node 16 though. Quick fix for now, I may fork drivelist @9.2.4 and update it to work with node16 when I get a chance