balena-io-modules / drivelist

List all connected drives in your computer, in all major operating systems
Apache License 2.0
238 stars 90 forks source link

Do it works on node 19.6.0? #423

Open crystalfp opened 1 year ago

crystalfp commented 1 year ago

Upgraded node from 18.13.4 to 19.6.0 and now npm update complains that Unsupported engine because it requires node: '>=16 < 19'. Later today I will check if it still works, but in the meantime could a new version that works on node 19 be released? Thanks! mario

crystalfp commented 1 year ago

Strange. My installed version is 11.1.0 but the site pointed by npm said 6.4.3. I'm working on Windows 11. Thanks for clarifying! mario

lurch commented 1 year ago

The comments in #420 suggest that it only builds reliably on Node 14? :shrug:

lurch commented 1 year ago

My installed version is 11.1.0 but the site pointed by npm said 6.4.3.

Yeah, https://github.com/balena-io-modules/drivelist/tags says the latest "tag" is v11.1.0 but https://github.com/balena-io-modules/drivelist/releases says the latest "release" is v6.4.3 :confused: (EDIT: see also #419 )

crystalfp commented 1 year ago

It works under Node 19.8.1 so it seems a small change to package configuration is sufficient

bfan1256 commented 1 year ago

Any updates to this?