search

balena-io-modules / etcher-sdk

Apache License 2.0
42 stars 17 forks source link

lockfile 2 #234

Closed zwhitchcox closed 2 years ago

zwhitchcox commented 2 years ago

This pr upgrades the lockfile to version 2, a step towards compatibility with Node 16

Change-type: minor

mcraa commented 2 years ago

Seems like a known issue @zwhitchcox https://stackoverflow.com/a/45156653 I tried what they suggest but still no change https://github.com/balena-io-modules/etcher-sdk/commit/5abe371c052d5f6e382975196877c622f21f8a55

mcraa commented 2 years ago

I was too quick @zwhitchcox FYI using node 16.x instead of 14 makes it work with the prepare script.

zwhitchcox commented 2 years ago

Thanks @mcraa Does that mean we should switch back to thundron/lzma-native? I'm not sure if we still need 14 to work though...maybe we could do that later.

mcraa commented 2 years ago

no need to go back imo @zwhitchcox, the 7.2 npm package works fine with 14 or 16, just for testing/reviewing when I used the git repo directly in the package.json but it is a nice flag for us to see what needs to be done if we want to keep up with node