Fix `$orderby: { a: { $count: ... }, $dir: 'asc' }` typings

balena-io-modules / pinejs-client-js

4 stars 4 forks source link

Fix `$orderby: { a: { $count: ... }, $dir: 'asc' }` typings #137

Closed thgreasi closed 2 years ago

thgreasi commented 2 years ago

Apparently this was invalid b/c the value types are incompatible. Given that we can't type Extract<string, '$dir'> atm (& we don't have negated types) this was the best fix I could think.

Change-type: patch

thgreasi commented 2 years ago

Thanks for deep research checking @fisehara :pray: I will get this in since atm TS doesn't let us use the new orderby notation at all and we can improve it later if we get better ideas.

thgreasi commented 2 years ago

@balena-ci I self-certify!

thgreasi commented 2 years ago

@balena-ci republish