search

balena-io-modules / resin-device-logs

Resin.io device logs utilities.
Apache License 2.0
3 stars 2 forks source link

Uncaught, unspecified "error" event. (PNNetworkIssuesCategory) #21

Closed LucianBuzzo closed 7 years ago

LucianBuzzo commented 7 years ago

Front logo Front conversations

LucianBuzzo commented 7 years ago

Repro for this is simple refreshing the page whilst on the device summary

LucianBuzzo commented 7 years ago

If you don't add an event listener, then this line https://github.com/resin-io/resin-device-logs/blob/master/lib/logs.coffee#L90 will cause a thrown error. See https://github.com/Gozala/events/blob/master/events.js#L53 Is this desired behaviour?

emirotin commented 7 years ago

So we've discussed it and decided it's actually OK, the error is there and it's up to the downstream consumer to interpret it.