balena-io / balena-cli

The official balena CLI tool.
Apache License 2.0
455 stars 142 forks source link

appUpdatePollInterval should be updated (15min in balenaCloud) #1577

Open pdcastro opened 4 years ago

pdcastro commented 4 years ago

Some OS configuration commands (os configure, local configure, config generate...) have 10min hardcoded as the default value for appUpdatePollInterval in config.json. However, there are minimum values set in backend configuration, currently 15min for balenaCloud and 10min for openBalena. The CLI should not allow configuration of values below the minimum -- and certainly not recommend a default value that is below the minimum!

pdcastro commented 4 years ago

https://www.flowdock.com/app/rulemotion/r-supervisor/threads/-sJXR94993qrn1n5REn2_C9eqKS

the minimum value is shared in https://api.balena-cloud.com/config/vars that endpoint is available in both open and cloud balena

"RESIN_SUPERVISOR_POLL_INTERVAL": {
"type":"integer",
"description":"Define the balena API poll interval in milliseconds",
"default":900000,
"minimum":900000,
"maximum":86400000
}
myarmolinsky commented 2 years ago

The default and minimum poll interval is 10 minutes, see: https://github.com/balena-io/open-balena-api/blob/5007cbeb43304f1f72424b3338b4b2a7c421aff7/src/lib/config.ts#L337-L340 And we do not have an override here: https://github.com/balena-io/environment-production/blob/master/kubernetes/balenacloud/balena-api/configmap.yaml

See FD discussion about the minimum poll interval here: https://www.flowdock.com/app/rulemotion/public-s-community/threads/JQhGP_i2UgaNtnY62E7ZKScqePZ

The CLI should not allow configuration of values below the minimum

This part is still true. We've already prevented the user from entering values smaller than the minimum in the UI, see: https://github.com/balena-io-modules/rendition/pull/1601 . If the CLI currently allows such entering values smaller than the minimum, that should be amended.