balena-io / balena-cli

The official balena CLI tool.
Apache License 2.0
453 stars 138 forks source link

Filter old CLI versions when logging via sentry. #1630

Closed srlowe closed 2 years ago

srlowe commented 4 years ago

Unnecessary sentry logging is steadily being reduced in CLI releases, however we have no control over older versions that may still be in use. To reduce the amount of data logged to sentry we should:

It may make sense to do this after we have upgraded sentry client (since this will probably require changes to sentry library code, which would be replaced during sentry upgrade).

pdcastro commented 4 years ago

@srlowe, do you know/remember if we actually/already have a balena-controlled endpoint ("API sentry proxy route")? I know we do for Mixpanel (events.ts), but for Sentry it seems to use a sentry.io URL:

srlowe commented 4 years ago

@pdcastro Ah... this may have been a bad assumption on my part (because we had the proxy for mixpanel).

Hmm. Not sure how we could save this in that case. Even if we add proxy now, that doesn't stop old stuff getting through. We could in theory change our sentryid/DSN (if we wanted to stop old traffic, or direct traffic), but that might cause strange behaviour on the users' end when an error encountered.

srlowe commented 2 years ago

Closing, since we have no control over sentry endpoint.