balena-io / balena-cli

The official balena CLI tool.
Apache License 2.0
453 stars 139 forks source link

[homebrew] balena-cli 12.44.10 OSX build issue #2261

Open chenrui333 opened 3 years ago

chenrui333 commented 3 years ago

๐Ÿ‘‹ Ran into some build issue when building balena-cli 12.44.10

Full build log is in here, https://github.com/Homebrew/homebrew-core/runs/2504528887 relates to https://github.com/Homebrew/homebrew-core/pull/76565

pdcastro commented 3 years ago

@chenrui333, what do you think of packaging the balena CLI's standalone zip package for macOS instead of building from source? That's a binary package that bundles Node.js inside, so the formula would not have to declare a dependency on node.

I see in brew's Acceptable Formulae guidance that:

https://docs.brew.sh/Acceptable-Formulae#we-dont-like-binary-formulae We donโ€™t like binary formulae Our policy is that formulae in the core tap (homebrew/core) must be open-source with an Debian Free Software Guidelines license and either built from source or produce cross-platform binaries (e.g. Java, Mono). Binary-only formulae should go to homebrew/cask.

If it had to be a cask, so be it. The user experience would still be "brew install balena-cli".

I have never written a brew formula or cask, I'm just throwing the idea out there. :-)

Additional considerations: