balena-io / balena-sdk

The SDK to make balena powered JavaScript applications.
https://www.balena.io/
Apache License 2.0
146 stars 46 forks source link

add methods necessary for preloading #1291

Closed aethernet closed 1 year ago

aethernet commented 1 year ago

Change-type: patch Signed-off-by: Edwin Joassart edwin.joassart@balena.io

See:

Depends-on: https://github.com/balena-io/open-balena-api/pull/1081 Change-type: patch


Contributor checklist
aethernet commented 1 year ago

Tests are expected to fails until https://github.com/balena-io/open-balena-api/pull/1081 is merged in balena-open-api.

aethernet commented 1 year ago

Note: While waiting for https://github.com/balena-io/open-balena-api/pull/1081 I'm skipping the test for that method so I can use the draft published to npm for dev purposes.

aethernet commented 1 year ago

@thgreasi It's ready to be reviewed :)

But I'll keep it as a draft until https://github.com/balena-io/open-balena-api/pull/1081 is merged, the tests are ready but cannot pass without that PR in prod. (I ran the test against my bob and they're passing)

aethernet commented 1 year ago

with open-balena-api 7.13.0 the missing endpoint are now in. but we still need for the update in balena-api then release to prod env for tests to pass https://github.com/balena-io/balena-api/pull/4114

aethernet commented 1 year ago

The previously missing endpoint is now in production, so I turn the tests back on and from my POV this is ready for a last review then merge.

aethernet commented 1 year ago

I Self-Certify!