balena-io / balena-sdk

The SDK to make balena powered JavaScript applications.
https://www.balena.io/
Apache License 2.0
145 stars 46 forks source link

Fix auth.twoFactor.isEnabled() regression returning always true #1337

Closed thgreasi closed 1 year ago

thgreasi commented 1 year ago

Update balena-auth from 4.1.0 to 4.2.0

Change-type: patch

Resolves: # HQ: See: Depends-on: Change-type: major|minor|patch


Contributor checklist
otaviojacobi commented 1 year ago

hey @thgreasi are the environment variables set-up for the 2FA tests? The tests are being skipped https://github.com/balena-io/balena-sdk/actions/runs/5112147480/jobs/9189895132?pr=1337#step:6:1956

But at least the most important one for this PR runs and passes: https://github.com/balena-io/balena-sdk/actions/runs/5112147480/jobs/9189895132?pr=1337#step:6:1951

thgreasi commented 1 year ago

Yes I've already added them @otaviojacobi :thinking: I see that the envs were missing from the karma.conf.js, but that doesn't explain why the tests didn't run in node :thinking:

thgreasi commented 1 year ago

I self-certify!