search

balena-io / balena-sdk

The SDK to make balena powered JavaScript applications.
https://www.balena.io/
Apache License 2.0
145 stars 46 forks source link

Add SauceLabs or BrowserStack tests #238

Closed emirotin closed 4 years ago

emirotin commented 7 years ago

We need to test this module (and ideally lower-level sub-modules) in the real browsers. PhantomJS is OK to check the compatibility with generic browser environment, but it's not the real browser.

I've recently hit a bug where Chrome had different implementation of some internal property.

jviotti commented 7 years ago

Could https://github.com/resin-io-modules/resin-config-karma be useful here?

emirotin commented 7 years ago

I already use it, but the target is currently PhantomJS which runs on the CI box. The key is to use the real browsers like actual version of Chrome. If it works with the same config it's great, but in my understanding it should be run on a different platform, like SauceLabs. Correct me if I'm wrong.

On Tue, Dec 13, 2016 at 5:52 PM, Juan Cruz Viotti notifications@github.com wrote:

Could https://github.com/resin-io-modules/resin-config-karma be useful here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/resin-io/resin-sdk/issues/238#issuecomment-266758528, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgGCMWxskTQ41vfnfi244d-5fw3RKcSks5rHrFFgaJpZM4LLr3X .

-- Eugene Mirotin Senior Frontend Engineer site: Resin.io https://resin.io/, twitter: @resin_io https://twitter.com/resin_io

jviotti commented 7 years ago

We do use SauceLabs for resin-config-karma. See https://github.com/resin-io-modules/resin-config-karma/blob/master/launchers.json for the list of browsers this will run against.

jviotti commented 7 years ago

Feel free to tweak the list of browsers we should support!

emirotin commented 7 years ago

Oh, I didn't know about it, great.

On Tue, Dec 13, 2016 at 6:27 PM, Juan Cruz Viotti notifications@github.com wrote:

Feel free to tweak the list of browsers we should support!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/resin-io/resin-sdk/issues/238#issuecomment-266767986, or mute the thread https://github.com/notifications/unsubscribe-auth/AAgGCOihqwd-bZJx718oCdAmf4ir4Up_ks5rHrlLgaJpZM4LLr3X .

-- Eugene Mirotin Senior Frontend Engineer site: Resin.io https://resin.io/, twitter: @resin_io https://twitter.com/resin_io

thgreasi commented 4 years ago

Closing in favor of using balenaCI. See: https://github.com/balena-io/balena-sdk/issues/582