search

balena-io / balena-sdk

The SDK to make balena powered JavaScript applications.
https://www.balena.io/
Apache License 2.0
145 stars 46 forks source link

Take settings in constructor, and stop using resin-settings-client #310

Open pimterry opened 7 years ago

pimterry commented 7 years ago

See https://github.com/resin-io/resin-sdk/pull/226#issuecomment-296626478

emirotin commented 7 years ago

Once implemented we should also drop this piece of code https://github.com/resin-io/resin-sdk/pull/226/files#diff-a14896ddcadbe67fdbefec1a538a08eaR54 and use settings.get('dashboardUrl')

emirotin commented 7 years ago

But we should also carefully check how it works when the apiUrl is set to custom value