search

balena-io / contracts

Balena.io Base Contracts
Apache License 2.0
16 stars 28 forks source link

PR to add Owasys owa5X device #347

Closed owzagj closed 1 year ago

owzagj commented 1 year ago

Change-type: patch Adding Owasys owa5X device to the contracts repo

floion commented 1 year ago

Hi, please follow th exact commit I referenced. Change-type should be last. And follow new lines convention also

owzagj commented 1 year ago

I am afraid I do not understand what may I follow that had not, and what you mean by follow new lines convention. Furthermore, What does it mean Change-type should be last? More explicit instructions would save time as less iterations would be required.

Excuse me for the inconvenience a thanks in advance.

BR

floion commented 1 year ago

Hi, so as per https://github.com/balena-io/contracts/pull/296/commits/5291c89d7d8fcfdea33591ef664cc5ceb3b7c8ac the commit would be in this form:

Header that mentions the component modified

Optional details with description of what the commit does

Change-type:
Signed-off-by:

The new lines I mentioned in in my comment are the new lines between the header, the optional details and the footer as you can see also above. In your commit the Change-type is in the header.