balena-io / contracts

Balena.io Base Contracts
Apache License 2.0
16 stars 28 forks source link

node: do not set unsafe-perm with npm 9 and newer #367

Closed mtoman closed 1 year ago

mtoman commented 1 year ago

The unsafe-perm config option has been dropped in npm 9, trying to set it ends with an error and therefore fails the build. With this patch the build script parses the major version from npm --version and only sets unsafe-perm on npm 8 and older.

jellyfish-bot commented 1 year ago

[klutchell] This has attached https://jel.ly.fish/7397ca2b-7352-48be-9fad-265261450704

klutchell commented 1 year ago

lgtm