balena-io / contracts

Balena.io Base Contracts
Apache License 2.0
16 stars 28 forks source link

hw.device-type: Modify bluechiptechnology-tm3 #398

Closed chrisruk closed 10 months ago

chrisruk commented 10 months ago

Change-type: patch

I found https://github.com/balena-io/contracts/blob/master/contracts/hw.device-type/rockpi-4b-rk3399/contract.json and https://docs.balena.io/learn/getting-started/rockpi-4b-rk3399/nodejs/ which appear to have the same installation process

Which I've adapted below -

I wasn't quite sure how the 'partials' maps to the above text though.

chrisruk commented 10 months ago

I'm just wondering also if I should change

    "storage": {
      "internal": true
    },
    "media": {
      "defaultBoot": "sdcard",
      "altBoot": ["internal"]
    },

To:

    "storage": {
      "internal": true
    },
    "media": {
      "defaultBoot": "internal",
      "altBoot": ["sdcard"]
    },

Originally I thought the first syntax was correct, as the TM3 boots from an SD card if one is inserted and otherwise boots from eMMC.

But now I'm thinking because we're using a 'flashing' image, we should use the latter syntax, as Balena will generally be run from eMMC?

floion commented 10 months ago

I'm just wondering also if I should change

    "storage": {
      "internal": true
    },
    "media": {
      "defaultBoot": "sdcard",
      "altBoot": ["internal"]
    },

To:

    "storage": {
      "internal": true
    },
    "media": {
      "defaultBoot": "internal",
      "altBoot": ["sdcard"]
    },

Originally I thought the first syntax was correct, as the TM3 boots from an SD card if one is inserted and otherwise boots from eMMC.

But now I'm thinking because we're using a 'flashing' image, we should use the latter syntax, as Balena will generally be run from eMMC?

Hi, yes, please make that change also