search

balena-io / contracts

Balena.io Base Contracts
Apache License 2.0
16 stars 28 forks source link

Added contract for revpi-connect-4 #401

Closed wickywaka closed 9 months ago

floion commented 9 months ago

Hi @wickywaka aside from the proper logo, what else does this PR need to be final?

wickywaka commented 9 months ago

Hi @wickywaka aside from the proper logo, what else does this PR need to be final?

For this PR just the logo is needed.

chrblabla commented 9 months ago

Thank you @wickywaka for this contribution. @nbuchwitz would you be able to provide a logo here?

chrblabla commented 9 months ago

Hint: the Revolution Pi Connect 4 optionally supports Wifi and Bluetooth, not sure how Balena handles this. Would it need two device contracts (one with and one without wireless connectivity)?

floion commented 9 months ago

@chrblabla in such a case we have the contract describe the full variant of the hardware. So here it would mean the contract should list both wifh and bluetooth as available

wickywaka commented 9 months ago

Ok, I will make the changes then

On Wed, 8 Nov 2023, 12:04 Florin Sarbu, @.***> wrote:

@chrblabla https://github.com/chrblabla in such a case we have the contract describe the full variant of the hardware. So here it would mean the contract should list both wifh and bluetooth as available

— Reply to this email directly, view it on GitHub https://github.com/balena-io/contracts/pull/401#issuecomment-1801658325, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVDYA67NHBL2J52FYE7VGTYDNRMXAVCNFSM6AAAAAA67RL4Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRGY2TQMZSGU . You are receiving this because you were mentioned.Message ID: @.***>

floion commented 9 months ago

Thanks @wickywaka can you squash both commits into just one and also add the proper icon so we can have this merged?

wickywaka commented 9 months ago

Thanks @wickywaka can you squash both commits into just one and also add the proper icon so we can have this merged?

@floion Done.

floion commented 9 months ago

Hi @wickywaka this needs a Change-type like https://github.com/balena-io/contracts/pull/400/commits/2bbde3e92d6e1a6c3f9d63e9e79b14b70b755f80 for example

wickywaka commented 9 months ago

I hope this

Hi @wickywaka this needs a Change-type like 2bbde3e for example

Done. Can you add the ok-to-test label.

Also what is correct workflow for this type of PR from a fork? There should be an easy for you to make changes in the source branch.

floion commented 9 months ago

Thanks. We can't do any changes to PRs form forks. Not even rebase them

floion commented 9 months ago

Can you remove the Changelog-entry and rebase on top of master please?

wickywaka commented 9 months ago

Can you remove the Changelog-entry and rebase on top of master please?

Done.

wickywaka commented 9 months ago

Thanks. We can't do any changes to PRs form forks. Not even rebase them

I see something about this in Github docs but don't see the option here, may be it only shows up at the time when a new PR is created. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

floion commented 9 months ago

After the Signed-off-by line this commit has the word comit in it which breaks versioning. Please remove that line and the empty line above it

wickywaka commented 9 months ago

After the Signed-off-by line this commit has the word comit in it which breaks versioning. Please remove that line and the empty line above it

I am extremely sorry. I hope its fixed now.