Closed wickywaka closed 9 months ago
Hi @wickywaka aside from the proper logo, what else does this PR need to be final?
For this PR just the logo is needed.
Thank you @wickywaka for this contribution. @nbuchwitz would you be able to provide a logo here?
Hint: the Revolution Pi Connect 4 optionally supports Wifi and Bluetooth, not sure how Balena handles this. Would it need two device contracts (one with and one without wireless connectivity)?
@chrblabla in such a case we have the contract describe the full
variant of the hardware. So here it would mean the contract should list both wifh and bluetooth as available
Ok, I will make the changes then
On Wed, 8 Nov 2023, 12:04 Florin Sarbu, @.***> wrote:
@chrblabla https://github.com/chrblabla in such a case we have the contract describe the full variant of the hardware. So here it would mean the contract should list both wifh and bluetooth as available
— Reply to this email directly, view it on GitHub https://github.com/balena-io/contracts/pull/401#issuecomment-1801658325, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVDYA67NHBL2J52FYE7VGTYDNRMXAVCNFSM6AAAAAA67RL4Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBRGY2TQMZSGU . You are receiving this because you were mentioned.Message ID: @.***>
Thanks @wickywaka can you squash both commits into just one and also add the proper icon so we can have this merged?
Thanks @wickywaka can you squash both commits into just one and also add the proper icon so we can have this merged?
@floion Done.
Hi @wickywaka this needs a Change-type like https://github.com/balena-io/contracts/pull/400/commits/2bbde3e92d6e1a6c3f9d63e9e79b14b70b755f80 for example
I hope this
Hi @wickywaka this needs a Change-type like 2bbde3e for example
Done. Can you add the ok-to-test
label.
Also what is correct workflow for this type of PR from a fork? There should be an easy for you to make changes in the source branch.
Thanks. We can't do any changes to PRs form forks. Not even rebase them
Can you remove the Changelog-entry and rebase on top of master please?
Can you remove the Changelog-entry and rebase on top of master please?
Done.
Thanks. We can't do any changes to PRs form forks. Not even rebase them
I see something about this in Github docs but don't see the option here, may be it only shows up at the time when a new PR is created. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
After the Signed-off-by
line this commit has the word comit
in it which breaks versioning. Please remove that line and the empty line above it
After the
Signed-off-by
line this commit has the wordcomit
in it which breaks versioning. Please remove that line and the empty line above it
I am extremely sorry. I hope its fixed now.
Hi @wickywaka aside from the proper logo, what else does this PR need to be final?