search

balena-io / contracts

Balena.io Base Contracts
Apache License 2.0
16 stars 28 forks source link

Add support for Ubuntu Noble #432

Closed ruffsl closed 4 days ago

ruffsl commented 1 month ago

This PR contains the following changes:

- Add support for Ubuntu Noble.
klutchell commented 1 week ago

Thanks for the contribution @ruffsl ! Would you mind rebasing your branch on the latest from master?

Note that it needs to be a rebase, not an "update". After a rebase there should still only be one commit in your branch, and no merge commits.

klutchell commented 1 week ago

Would you mind amending your commit message to include Change-type: patch in the footer?

klutchell commented 1 week ago

Also I suggest looking at this commit as an example as there may be some dependencies files that need updating.

ruffsl commented 1 week ago

as there may be some dependencies files that need updating.

I'm not sure how to go about this. Is there a script of some sort to auto update those partial templates here?

ruffsl commented 4 days ago

ping @klutchell , PR rebased. Looks like CI is passing.

klutchell commented 4 days ago

Great! I think the only thing that is missing now is the custom templates for ubuntu@noble.

A good starting point is to look at the existing templates for jammy, and create an identical corresponding template for noble.

./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi400-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+coral-dev/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberry-pi2/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi3-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi0-2w-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi4-64/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+revpi-core-3/dependencies.tpl
./contracts/sw.os+hw.device-type/ubuntu@jammy+raspberrypi3/dependencies.tpl

Then a quick check to see if the names of any packages in those templates have changed between jammy and noble.

Once that is done I can open a draft PR on the base-images repo to point to your contracts branch and see if everything generates!

ruffsl commented 4 days ago

Ok, I've duplicated the templates for ubuntu@noble. None of the package names seems to have changed, including: