balena-io / deploy-to-balena-action

Official Github action to deploy releases to balenaCloud environments
Apache License 2.0
38 stars 13 forks source link

Warning: The `set-output` command is deprecated and will be disabled soon. #233

Closed maggie44 closed 1 year ago

maggie44 commented 1 year ago

There are two warnings in the logs of builds like the below when using the action.

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Here is the GitHub notification on it: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I can't see any instances of set-output in the code, so it is probably just a matter of bumping a few packages up to start using the versions that have updated this.

Here is an example for @actions/core: https://github.com/actions/toolkit/issues/1218#issuecomment-1292412551

klutchell commented 1 year ago

We are calling the setOutput function from the @actions/core library, so we need to bump it to 1.10.0 as you said https://github.com/balena-io/deploy-to-balena-action/blob/c9d7b49b03ee6d083c6298d48e79cf93a7678914/src/action.ts#L143-L144

Action authors who are using the toolkit should update the @actions/core package to v1.10.0 or greater to get the updated saveState and setOutput functions.

klutchell commented 1 year ago

This PR should have fixed it, but we closed it. https://github.com/balena-io/deploy-to-balena-action/pull/221