balena-io / deploy-to-balena-action

Official Github action to deploy releases to balenaCloud environments
Apache License 2.0
38 stars 13 forks source link

Add debug build logs option #261

Closed treygilliland closed 1 year ago

treygilliland commented 1 year ago

Change-type: minor

This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs.

This PR has been modeled after a similar PR to add the --multi-dockerignore flag here

treygilliland commented 1 year ago

@thgreasi @klutchell Hello! I am looking to add the --debug flag (and the --note flag as well to come in another PR) for use in the balena push command but will need the approval to run these workflows.

Thanks!

klutchell commented 1 year ago

Thank you for the contribution @treygilliland ! We will have a look over the changes soon!

In order to pass the versioning steps you'll need to add Change-type: minor to the footer of one of your commits and force push again. You can also squash the second commit as a fixup.

If you're using git from the command line something like this should work.

  1. git rebase -i HEAD~2 to start an interactive rebase, which will open an editor showing your two commits
  2. change the first column of the commit from pick to r for re-word
  3. change the first column second commit from pick to f for fixup
  4. save and exit, another editor will open to change the wording of the first commit
  5. add the extra footer to the commit message
  6. git push -f -u origin/add-debug-option
klutchell commented 1 year ago

Your changes look good to me @treygilliland , see my previous comment for unblocking the tests by fixing your commit message.

treygilliland commented 1 year ago

@klutchell sorry just got around to this. Thanks for the great instructions! Does it look like it worked?

klutchell commented 1 year ago

LGTM