Closed treygilliland closed 1 year ago
@thgreasi @klutchell Hello! I am looking to add the --debug
flag (and the --note
flag as well to come in another PR) for use in the balena push
command but will need the approval to run these workflows.
Thanks!
Thank you for the contribution @treygilliland ! We will have a look over the changes soon!
In order to pass the versioning steps you'll need to add Change-type: minor
to the footer of one of your commits and force push again. You can also squash the second commit as a fixup.
If you're using git from the command line something like this should work.
git rebase -i HEAD~2
to start an interactive rebase, which will open an editor showing your two commitspick
to r
for re-wordpick
to f
for fixupgit push -f -u origin/add-debug-option
Your changes look good to me @treygilliland , see my previous comment for unblocking the tests by fixing your commit message.
@klutchell sorry just got around to this. Thanks for the great instructions! Does it look like it worked?
LGTM
Change-type: minor
This change adds an option to use the
--debug
flag to the Balena push command to allow to see debug build logs.This PR has been modeled after a similar PR to add the
--multi-dockerignore
flag here