search

balena-io / deploy-to-balena-action

Official Github action to deploy releases to balenaCloud environments
Apache License 2.0
38 stars 13 forks source link

Enable adding a note to the release #274

Closed treygilliland closed 11 months ago

treygilliland commented 11 months ago

This change adds an option to use the --debug flag to the Balena push command to allow to see debug build logs.

This PR has been modeled after a similar PR to add the --multi-dockerignore flag here

Change-type: minor

treygilliland commented 11 months ago

@klutchell I tried to follow what I did in my previous PR to get CI to run but not sure what went wrong. I'm looking to add the --note flag so I can note which branch the release came from. Any help would be appreciated!

klutchell commented 11 months ago

Hey @treygilliland, thanks for the additional contribution!

It's difficult to tell, but I think you need an empty line between the commit title and the Commit-type in the body.

e.g.

Enable adding a note to the release
Change-type: minor

vs

Enable adding a note to the release

Change-type: minor

I know it seems silly, our versioning is using a legacy tool that could use some TLC.

klutchell commented 11 months ago

Resolves: https://github.com/balena-io/deploy-to-balena-action/issues/194

treygilliland commented 11 months ago

Hey @treygilliland, thanks for the additional contribution!

It's difficult to tell, but I think you need an empty line between the commit title and the Commit-type in the body.

e.g.

Enable adding a note to the release
Change-type: minor

vs

Enable adding a note to the release

Change-type: minor

I know it seems silly, our versioning is using a legacy tool that could use some TLC.

I think I added this but not sure.

klutchell commented 11 months ago

Ugh, I found what was wrong and it's worse than I thought.

You'll need to make your Change-type: the last line of your commit, or at least at the bottom with other "footer" type entries, with your descriptive text in the body.

Apologies for the confusion, but at least now we know where the culprit is!

treygilliland commented 11 months ago

Ugh, I found what was wrong and it's worse than I thought.

You'll need to make your Change-type: the last line of your commit, or at least at the bottom with other "footer" type entries, with your descriptive text in the body.

Apologies for the confusion, but at least now we know where the culprit is!

All good. I think I have done that now (also removed the other text) with no luck...

klutchell commented 11 months ago

For security reasons we need to add the ok-to-test label for every push, but it looks like it has started now.

klutchell commented 11 months ago

Depends on: https://github.com/balena-io/deploy-to-balena-action/pull/275

klutchell commented 11 months ago

Can you rebase your commit please @treygilliland ?

treygilliland commented 11 months ago

@pipex @klutchell added trim to if statement, please retag for CI when you get a chance (no rush) :)

klutchell commented 11 months ago

Thank you for the contribution @treygilliland !