search

balena-io / etcher

Flash OS images to SD cards & USB drives, safely and easily.
https://etcher.io/
Apache License 2.0
29.27k stars 2.08k forks source link

Etcher commit guidlines does not match resin commit requirements #2476

Open amdomanska opened 5 years ago

amdomanska commented 5 years ago

Etcher commit guidelines (https://github.com/resin-io/etcher/blob/master/docs/COMMIT-GUIDELINES.md) does not match resin commit requirements. Issues:

  1. Etcher guideline require subject of the commit to NOT have the first letter capitalised. On the other hand resin commit lint (https://github.com/resin-io/resin-commit-lint) requires that to be capitalised.
  2. Etcher guideline does NOT require Change-type tag while resin-commit-lint requires that tag for at least one commit.

Following the etcher guidelines results with failed commit check after submitting the PR.

lurch commented 5 years ago

@jviotti will know more, but IIRC the Etcher versionist config is also deliberately different to the "standard" versionist config.

jhermsmeier commented 5 years ago

@lurch the resin-wide commit format has changed a bit, but Etcher's commit guidelines haven't caught up with it yet ;)

lurch commented 5 years ago

/me crawls back under his rock :wink: