balena-io / open-balena-api

The core API of openBalena
https://balena.io/open
GNU Affero General Public License v3.0
59 stars 29 forks source link

API uses deprecated host envvars #48

Open hedss opened 5 years ago

hedss commented 5 years ago

Most HOST variables have changed in name in the closed API, (eg. VPN_HOST is now BALENA_VPN_HOST, etc.). We should alter the open API to follow these changes.

dfunckt commented 5 years ago

@hedss did similar changes occur to VPN and registry?

BTW, to handle this, we'll need to:

  1. update open-balena to pass both old and new env vars
  2. update open-balena-api to use the new env vars
  3. update open-balena to remove old env vars
hedss commented 5 years ago

@dfunckt Yes, if you look at https://github.com/balena-io/open-balena-base/pull/62/files you'll see the list of altered HOST names. Each component was changed to rename them from RESIN to BALENA at the time.