search

balena-io / open-balena

Open source software to manage connected IoT devices at scale
https://balena.io/open
GNU Affero General Public License v3.0
1.04k stars 164 forks source link

Dependency upgrades (API v0.209.2) #149

Closed bartversluijs closed 2 years ago

bartversluijs commented 2 years ago

I've updated the following dependencies:

I've tested the changes by creating a new instance of open-balena. The following OS's have been tested with Balena CLI 13.1.13:

What I've tested with these BalenaOS versions:

ghost commented 2 years ago

Your landr site preview has been successfully deployed to https://landr-bartversluijs-repo-open-balena-preview-149.netlify.app

Deployed with Landr 9.4.20

richbayliss commented 2 years ago

I found this too @bartversluijs so I would 👍🏻 your MR if I could 😄

It would be useful if the Supervisor could detect the 404 and actually offer a more user-friendly error message; or if possible revert to the v2 state endpoint.

bartversluijs commented 2 years ago

Thanks @richbayliss,

I'm still doubting if I should change the open-balena-api version to v2.0.0 (because that's the latest). But I'm awaiting some feedback for that.

About the 404, I don't know if it should be changed. There's a new API (v3) and the latest BalenaOS uses that. For backward compatibility, supporting v2 would suffice, but isn't that a "hacky" solution?

In my opinion, only the API should support the older endpoints for backwards compatibility, but if there's a new release of BalenaOS that makes use of new endpoints, the API should be updated. Otherwise, you'd always have to support older endpoints of the API as fallback just in case the API isn't updated yet. So if the endpoint doesn't exist yet, you have two options:

I'm really thankful for openbalena, but (and I'm shooting myself in the foot here) I believe that openbalena users should adjust to the work the Balena team is doing instead of Balena testing and supporting all sorts of scenario's (like this one). As long as the latest BalenaOS version works with the latest open-balena-api, I'm happy to invest time to test the upgrade and making a PR 🙂

richbayliss commented 2 years ago

I guess the issue here is that a new OS was released, and wasn't checked against the current openBalena distribution for compatibility so the docs could be updated before the distribution was ready.

I also don't know what the solution is @bartversluijs but I feel that this current situation isn't a good one :)

It would be nice if there was a way to tag the open-balena-api images so that we have not just a latest tag but also a stable tag --- the latter being an API version we can update to with some degree of confidence that it's not got breaking changes with the OS etc 🤷🏻 or something to that effect...