search

balena-io / pensieve

A tool for managing and viewing structured documents, backed by the power of git
7 stars 5 forks source link

Should permalink strip the 'search' part of the URL? #260

Open lurch opened 6 years ago

lurch commented 6 years ago

When looking at e.g. https://resin-io.github.io/scratchpad/?0%5Bn%5D=Full%20text%20search&0%5Bv%5D=spectre I wonder if it'd make sense for the 'permalink' button to link to e.g. https://resin-io.github.io/scratchpad/#e5a0e8d0-02c9-11e8-8f16-b9bba40696cf Currently it links to https://resin-io.github.io/scratchpad/?0%5Bn%5D=Full%20text%20search&0%5Bv%5D=spectre#e5a0e8d0-02c9-11e8-8f16-b9bba40696cf (although I dunno if that means that 'accidentally' clicking on the permalink would then mess up your current filter?)

I guess in the worst-case-scenario the current permalink might actually fail if the original entry got edited such that the search-text (in this case spectre) no longer appeared in the entry?

lurch commented 6 years ago

Also, perhaps the fact that there even is a 'permalink' should be made more obvious by always showing the link button next to the entry's title? (while still showing the link icon only on-hover for the subheadings)