balena-labs-projects / balena-dash

Build a Raspberry Pi based desktop dashboard for stats, photos, videos and more!
https://balena.io/blog/make-a-web-frame-with-raspberry-pi-in-30-minutes/
MIT License
432 stars 137 forks source link

Move to balenaCloud hosted browser block. #148

Closed phil-d-wilson closed 2 years ago

phil-d-wilson commented 2 years ago

Change-type: major Signed-off-by: Phil Wilson phil@balena.io

Also swap Tahora for browsercontrol block

ghost commented 2 years ago

An error occurred whilst building your landr site preview:

{
  "name": "Error",
  "message": "Cannot handle unknown node `table`",
  "stack": "Error: Cannot handle unknown node `table`\n    at Object.unknown (/usr/src/app/node_modules/mdast-util-to-markdown/lib/index.js:65:9)\n    at Object.one [as handle] (/usr/src/app/node_modules/zwitch/index.js:20:25)\n    at flow (/usr/src/app/node_modules/mdast-util-to-markdown/lib/util/container-flow.js:15:15)\n    at Object.root (/usr/src/app/node_modules/mdast-util-to-markdown/lib/handle/root.js:6:10)\n    at Object.one [as handle] (/usr/src/app/node_modules/zwitch/index.js:20:25)\n    at toMarkdown (/usr/src/app/node_modules/mdast-util-to-markdown/lib/index.js:38:20)\n    at compile (/usr/src/app/node_modules/remark-stringify/index.js:13:12)\n    at Function.stringify (/usr/src/app/node_modules/unified/index.js:341:12)\n    at Object.getMarkdownSection (/usr/src/app/node_modules/scrutinizer/build/lib/utils/markdown.js:78:64)\n    at async exports.default (/usr/src/app/node_modules/scrutinizer/build/lib/plugins/readme-sections.js:62:16)"
}
phil-d-wilson commented 2 years ago

@rahul-thakoor

I've tested on Pi3, Pi4 and NUC, both the browser and the browser control. We would need to update the balenaDash readme, and blog posts - but could you review from a technical standpoint.

rahul-thakoor commented 2 years ago

Thanks @phil-d-wilson

I've tested with a Pi4 + PiDisplay on balenaOS v2.94.4 and the display does not work. This is because vc4-kms-v3d is the default on new os releases. we have 2 options

  1. use vc4-fkms-v3d. This means balenaDash will be compatible on older releases too
  2. Keep vc4-kms-v3d as default and instruct users on how to use PiDisplay. Also means PiDisplay and balenaDash v2 won't work on older balenaOS versions

I've chosen option 1: added BALENA_HOST_CONFIG_dtoverlay: "vc4-fkms-v3d" to use FKMS mode. Tested working with PiDisplay

phil-d-wilson commented 2 years ago

@balena-ci I self-certify!