search

balena-labs-projects / balena-node-red

a node-red application with balena-supervisor support, can be managed remotely via balena publicURL
Apache License 2.0
60 stars 59 forks source link

Update balena.yml to conform to the new requirements/format. #38

Closed PranavPeshwe closed 3 years ago

PranavPeshwe commented 3 years ago

Following the discussion regarding the version key here and referring to the balena.yml from balena-dash, I've omitted the version key in the contract.

Testing done:

tmigone commented 3 years ago

@pranavpeshwe, thanks :) Minor nitpicks, can you squash the commits into a single one? and also I think patch as a change type is more appropriate as this is not really introducing anything new.

PranavPeshwe commented 3 years ago

@pranavpeshwe, thanks :) Minor nitpicks, can you squash the commits into a single one? and also I think patch as a change type is more appropriate as this is not really introducing anything new.

Thanks for the comment, and nitpicks are important & welcome 👍🏻
Shall squash the commits and raise a new PR. Tried an interactive rebase to squash in-PR, but didn't work as intended. Will change the type to 'patch' if that is the convention. I thought that we introduced/enforced a new format that is incompatible with the one present earlier hence changed the minor version.