search

balena-labs-projects / rosetta-at-home

80 stars 17 forks source link

ram_max_used fix ineffective on updated devices due to persistent storage #29

Closed ptrm closed 4 years ago

ptrm commented 4 years ago

As the /usr/app/boinc folder became a volume, the changes fixing #25 do not come to life on existing instances: Screenshot from 2020-04-24 18-10-34

Only one of the global override files was edited, but this seems to not matter.

ptrm commented 4 years ago

...which can probably be fixed for balena-managed devices from foldforcovid.io using rosetta project preferences.

chrisys commented 4 years ago

@ptrm ah yes, we should add a sed action to update existing devices - I'll do another PR for that. Thanks for your continued work testing this project! :)

ptrm commented 4 years ago

Thanks! I myself started scribbling a bash script with checks and substitutions only if max ram is greater than 95% and same for cpu. Also with a env variable with flags to skip the checks. Should come around the weekend

chrisys commented 4 years ago

@ptrm by all means PR your work, I'd love to include it!

chrisys commented 4 years ago

Just a note, if you do decide to PR, take a look at the contribution guidelines for balenaSound, the same will apply here with regards to the CI: https://github.com/balenalabs/balena-sound/blob/master/CONTRIBUTING.md

ptrm commented 4 years ago

Added a pull request, though I have to admit that after #27 my 4GB Pi 4 still loses ui from time to time but is still steadily working. And the 2GB Pi 4 reboots with more than one task - tried forcing 3 and 2 cores as well.

And sorry for the merge commit - forgot to sync with the root repo before creating the PR.

chrisys commented 4 years ago

@ptrm great work, I was just testing your PR and seeing the same reboot issue on my 2GB Pi 4 unfortunately, so perhaps we should put the limit back up to 2500000 as it was before.