search

balena-labs-projects / xserver

A simple X11 server block
Apache License 2.0
15 stars 13 forks source link

vcgencmd is still run on non raspberry pi devices #11

Closed rahul-thakoor closed 1 year ago

rahul-thakoor commented 2 years ago

https://github.com/balenablocks/xserver/blob/fb2250ce8a768f32da33c7fc48f2a99b887624fb/src/entry.sh#L13

E.g on x64 device:

[Logs]    [9/28/2021, 15:34:50] [browser] /opt/xserver/entry.sh: 16: vcgencmd: not found
[Logs]    [9/28/2021, 15:34:50] [browser] /opt/xserver/entry.sh: 16: [: Illegal number:
jamwest commented 2 years ago

Having messed about with this I think it is due to using ENTRYPOINT in the Dockerfile.template file. When running in shell the shebang is not being respected. I believe this is also causing the cursor toggle issues some people are experiencing.

lukasknutti commented 2 years ago

is there a known fix for this? or some more explanation of what might cause this bug? (using an Intel NUC here)

nucleardreamer commented 1 year ago

@jamwest you are 100% correct here! Sometimes it's the small things that are very easily overlooked. I tested just replacing sh with bash on the ENTRYPOINT and it works as expected. I will be publishing a new version shortly.

@lukasknutti @jamwest @rahul-thakoor thank you guys for the patience on this issue, I know it's been a number of months!