search

balena-os / balena-beaglebone

Balena support for Beaglebone boards
https://www.balena.io/os/
Apache License 2.0
20 stars 18 forks source link

Add beagleplay support take 4 #679

Closed delhiryder closed 1 week ago

delhiryder commented 3 months ago

Opening a 'development' pull request, to allow the Balena team to inspect the proposed changes. Code is not (yet) building or running.

resin-jenkins commented 3 months ago

Can one of the admins verify this patch?

delhiryder commented 3 months ago

The Pull Request has been cleaned up and is now ready for review. Code is successfully building a balena-image-flasher target for the beageplay.

delhiryder commented 3 months ago

@floion - any updates on this ?

floion commented 3 months ago

@delhiryder please see the comments I left above.

Also, the Changelog-entry footer in the git commit log is supposed to be an entry reflecting what the PR changes / adds to the repository. So in your case, there is no need for a Changelog-entry in each commit saying what that commit has made, but rather you can pick one of the commits and add a changelog entry there which would simply say that the Beagleplay support was added.

floion commented 3 months ago

@resin-jenkins test this please

delhiryder commented 3 months ago

@floion - I have updated the PR with most of the changes you requested (and resolved the associated conversations). The two un resolved conversations are related to the the BALENA_BOOT_SIZE and IMAGE_ROOTFS_SIZE. I have carried out the investigations you asked for, and posted the results in these threads.

Let me know how you want to proceed.

delhiryder commented 3 months ago

Updated the PR. @floion please review and let me know if this looks ok.

delhiryder commented 3 months ago

@floion - rebased and updated the PR. Please take a look.

floion commented 1 week ago

Superseded by https://github.com/balena-os/balena-beaglebone/pull/686