search

balena-os / balena-engine

Moby-based Container Engine for Embedded, IoT, and Edge uses
https://www.balena.io
Apache License 2.0
695 stars 67 forks source link

Revisit pull retry policy #429

Closed lmbarros closed 1 year ago

lmbarros commented 1 year ago

We got a case in which our current pull retry policy wasn't "insistent enough" to allow for a proper update under an extremely unreliable network connection.

jellyfish-bot commented 1 year ago

[lmbarros] This has attached https://jel.ly.fish/623a2654-2fc5-4071-8a2b-ef8cd67f6a6f

lmbarros commented 1 year ago

Done in #430 . TL;DR: Pulls no longer time out; we'll keep on retrying for as long as needed (or the caller of the balenaEngine REST API closes the HTTP connection which, as before, is the way to give up and cancel the pull.)

For reference, this is the PR integrating this into balenaOS: https://github.com/balena-os/meta-balena/pull/3130