search

balena-os / balena-engine

Moby-based Container Engine for Embedded, IoT, and Edge uses
https://www.balena.io
Apache License 2.0
692 stars 66 forks source link

Add default port for API Swagger docs #447

Closed kb2ma closed 11 months ago

kb2ma commented 11 months ago

The swagger-docs target to the top level makefile builds the docs and makes them available on localhost port 9000. Add the port number to the README.

lmbarros commented 11 months ago

The ideal would be to try to get this merged upstream and then get the change via a merge or cherry-pick (to avoid diverging from Moby, and thus simplifying merges). Doesn't look like a controversial thing, so I guess this has a reasonable chance of being accepted.

What do you think, @kb2ma ?

kb2ma commented 11 months ago

I didn't realize this came directly from upstream. Sure, sounds like a worthwhile experiment. Let me first be sure my force-push fixes the error.

kb2ma commented 11 months ago

@lmbarros , the build has failed a couple of times now on the "Is custom" check. Have you seen this error before? Any idea on how to fix it?

lmbarros commented 11 months ago

I don't recall seeing this before, @kb2ma . Our last commit on this repo was almost 2 months ago. Maybe a flowzone regression created over this period?

kb2ma commented 11 months ago

Created moby/moby#46781, so closing this one.