search

balena-os / balena-intel

Balena support for Intel boards
https://www.balena.io/os/
Apache License 2.0
33 stars 19 forks source link

Enable PINCTRL_BROXTON support in the kernel #758

Closed memoryrs closed 4 weeks ago

memoryrs commented 1 month ago

Activate CONFIG_PINCTRL_BROXTON kernel config in order to enable the watchdog on Apollo Lake processor. The Apollo Lake GPIO watchdog driver depends on CONFIG_PINCTRL_BROXTON.

resin-jenkins commented 1 month ago

Can one of the admins verify this patch?

memoryrs commented 1 month ago

I created this PR in order to support my request in https://github.com/balena-os/balena-intel/issues/759. Thank you.

alexgg commented 1 month ago

@memoryrs could you please add:

Changelog-entry: 
Signed-off-by:

With a change description and a signature to the commit (see the history for other examples). It's needed by the automated checks.

memoryrs commented 1 month ago

@alexgg Many thanks for your review and approval. I've added a change description and a signature to the commit as requested. Is there any further action I need to take to progress this PR? I noticed that the automated checks are asking for the label 'ok-to-test', could you please help with that?

alexgg commented 1 month ago

@memoryrs could you please squash the commits into one that rebases cleanly over master? One a cleanly rebased branch can be merged.

memoryrs commented 1 month ago

@alexgg I've squashed the commits into one and believe that I now have a rebased branch. Please let me know if that's okay?

alexgg commented 1 month ago

@resin-jenkins ok to test

floion commented 1 month ago

@memoryrs @alexgg so is PINCTRL_BROXTON needed for the Generic x86_64 (GPT) machine? It looks like it's for another machine as per https://github.com/balena-os/balena-intel/issues/759#issuecomment-2288511893 so this PR here in this repo would not do any good because we do not have that machine in this repo

memoryrs commented 4 weeks ago

Hi @floion, we are currently using the Intel NUC device type (machine name genericx86-64), which is this repo as @alexgg helped clarify in https://github.com/balena-os/balena-intel/issues/759#issuecomment-2289057671. We've been using the Intel NUC for all our Motium devices on balenaCloud FYI.

alexgg commented 4 weeks ago

@resin-jenkins retest this please

floion commented 4 weeks ago

Thanks for the follow-up @memoryrs . I created from your PR https://github.com/balena-os/balena-intel/pull/762 to have it merged because our current build pipeline won't allow building from fork. So closing this PR and following up in 762

memoryrs commented 3 weeks ago

Thank you for your help @floion I intend to delete this branch and this fork but would like to make sure it won't impact https://github.com/balena-os/balena-intel/pull/762 you created first?

floion commented 3 weeks ago

You can delete it

memoryrs commented 3 weeks ago

@floion Thank you very much for getting this change merged. I've tested our device against this release version and the watchdog module is now working as expected. Much appreciate it.