search

balena-os / balena-raspberrypi

Balena support for RaspberryPI boards
https://www.balena.io/os/
Apache License 2.0
194 stars 76 forks source link

patch: Add GHA Built Test Deploy workflows #1158

Closed vipulgupta2048 closed 2 months ago

vipulgupta2048 commented 4 months ago

Adds build deploy test workflow to RPI device repo for all devices

Depends-on: https://github.com/balena-os/.github/pull/75 Depends-on: https://github.com/balena-os/meta-balena/pull/3512

klutchell commented 4 months ago

I was hoping to add all device types in a single PR so we can merge it and turn off the related Jenkins job at the same time.

If we add devices one at a time like this, we will flood the autokit with duplicate runs.

See the checklist I added to this PR: https://github.com/balena-os/balena-intel/pull/756

klutchell commented 4 months ago

Also remember that device repositories require Changelog-entry: not Change-type: to pass versionist.

vipulgupta2048 commented 4 months ago

@klutchell I explained my reasoning to add one here, and more will be added to this same PR https://balena.zulipchat.com/#narrow/stream/345889-balena-io.2Fos/topic/.5BLeviathan.5D.20GHA.20Migration/near/453426022

klutchell commented 3 months ago

@vipulgupta2048 I suggest syncing some of the changes I made to the workflows in this PR (or maybe we merge that one first) https://github.com/balena-os/balena-intel/pull/756

klutchell commented 2 months ago

LGTM

klutchell commented 2 months ago

Raspberry Pi Zero 2 W (64bit) is failing the os suite led identification test Balena RaspberryPi logs.zip

leviathan-client-1  | [2024-09-01T14:45:51.021Z][a20fc47-os]     ok 17 - Container exposed variables test # time=136414.855ms
leviathan-client-1  | [2024-09-01T14:45:54.304Z][a20fc47-os]     # Subtest: Identification test
leviathan-client-1  | [2024-09-01T14:45:54.305Z][a20fc47-os]         ok 1 - Response should be expected
leviathan-client-1  | [2024-09-01T14:46:19.382Z][a20fc47-os]         # Count is: 5
leviathan-client-1  | [2024-09-01T14:46:19.382Z][a20fc47-os]         not ok 2 - Led should have blinked multiple times
leviathan-client-1  |           ---
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]           found: false
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]           wanted: true
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]           compare: ===
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]           at:
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]             line: 118
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]             column: 15
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]             file: internal/util.js
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]             type: Test
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]             function: deprecated
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]           stack: |
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]             Proxy.run (/data/suite/tests/led/index.js:116:8)
leviathan-client-1  | [2024-09-01T14:46:19.383Z][a20fc47-os]           ...
leviathan-client-1  | [2024-09-01T14:46:19.389Z][a20fc47-os] 
leviathan-client-1  | [2024-09-01T14:46:19.390Z][a20fc47-os]         Bail out! Led should have blinked multiple times
leviathan-client-1  | [2024-09-01T14:46:19.392Z][a20fc47-os] Bail out! Led should have blinked multiple times
klutchell commented 2 months ago

Raspberry Pi Zero failed the Dtoverlay test. https://github.com/balena-os/balena-raspberrypi/actions/runs/10746131149/job/29807159484?pr=1158 Testbot Raspberry Pi OS (1).zip Balena RaspberryPi Logs (7).zip

klutchell commented 2 months ago

When testing with the changes from https://github.com/balena-os/meta-balena/pull/3512, all required device tests are passed 🎉

Removing the draft meta-balena branch and will rebase once merged to meta-balena.