balena-os / balena-supervisor

Balena Supervisor: balena's agent on devices.
https://balena.io
Other
150 stars 63 forks source link

Allow users to configure the retention limit on persistent logs for OS versions where persistent logs are on the data partition #1310

Open dt-rush opened 4 years ago

dt-rush commented 4 years ago

Ever since, in meta-balena, the commit

commit f69ff379ffac39dffcc126ac374b50533dcdef31
Author: Will Boyce <me@willboyce.com>
Date:   Fri Oct 25 12:10:46 2019 +0200

    resin-mounts: Move persistent logs from state to data partition

    Connects-to: #1646
    Change-type: minor
    Changelog-entry: Move persistent logs from state to data partition
    Signed-off-by: Will Boyce <will@balena.io>

(which went into v2.45.0 of the OS), we have had the possibility of users configuring RuntimeMaxUse= in /etc/systemd/journald.conf to be much larger than the default (32M or 64M, depending on OS version). However, this can only be done by hand at present; as well, this file is on the root partition and will be gone with host OS update swapping in the default file as cooked by yocto into the OS image, each time.

It should be possible to have the supervisor detect a variable and apply it to this file via sed, should the user configure their own desired persistent logging retention limit.

jellyfish-bot commented 4 years ago

[dt-rush] This issue has attached support thread https://jel.ly.fish/#/96750b3a-3269-46c8-a207-ae0c4b273737

jellyfish-bot commented 4 years ago

[mtoman] This issue has attached support thread https://jel.ly.fish/d0da7499-4450-4675-9d37-a7fbcaf6d9a6