Better error messaging with illegal/unsupported docker-compose fields

balena-os / balena-supervisor

Balena Supervisor: balena's agent on devices.

https://balena.io

Other

148 stars 63 forks source link

Better error messaging with illegal/unsupported docker-compose fields #1452

Open xginn8 opened 4 years ago

xginn8 commented 4 years ago

When setting some advanced networking configuration in docker-compose.yml, rather than failing early on during the build process, the services just failed at deploy time:

...
      networks:
         internal:
            ipv4_address: 10.0.0.2

jellyfish-bot commented 4 years ago

[xginn8] This issue has attached support thread https://jel.ly.fish/f64b8ecc-aec1-42be-81de-dad8aca571b4

20k-ultra commented 4 years ago

Just wanted to confirm that we are just adding better insight on why this configuration fail rather then just letting the container exit with whatever error balena engine throws. If this is the case then should we also have the CLI stop a build or log a warning when a build contains unsupported values ?