Do not report unique local IPv6 addresses on the current state

balena-os / balena-supervisor

Balena Supervisor: balena's agent on devices.

https://balena.io

Other

148 stars 63 forks source link

Do not report unique local IPv6 addresses on the current state #1934

Open pipex opened 2 years ago

pipex commented 2 years ago

Related to #1906 (see this comment in particular).

IPv6 ULA (Unique Local Address) RFC4193 are to IPv6 what RFC 1918 are to IPv4.

jellyfish-bot commented 2 years ago

[pipex] This issue has attached support thread https://jel.ly.fish/391d07d5-0bf1-40ef-9e58-01efedfbc97f

jellyfish-bot commented 2 years ago

[cywang117] This has attached https://jel.ly.fish/83958423-d3b7-4926-bf2a-2f1e970d1c7a

zoobot commented 2 years ago

We (@cywang117 ) think this should be addressed with a change to the db to accept longer text(ipv6 and mac addresses) so will open an issue with the api team. Otherwise it will still error. The table would be device

Column ip address mac address

Need to change varchar(255) (Short Text) to be Text (Type)

pipex commented 1 year ago

I don't think the API issue necessarily solves this problem. Unique local ipv6 addresses might still need some special treatment