balena-os / balena-supervisor

Balena Supervisor: balena's agent on devices.
https://balena.io
Other
148 stars 63 forks source link

Update dependencies node 20 pt 3 #2322

Closed cywang117 closed 5 months ago

cywang117 commented 5 months ago

chai cannot be bumped to v5, nor husky to v9, nor pretty-ms to v9, due to the Supervisor still being a CommonJS module and the aforementioned packages moving to ESM in those versions. Doing so will result in the ERR_REQUIRE_ESM error until we can migrate to an ESM module (type: module in package.json). See: https://github.com/chaijs/chai/issues/1561

Node 22 should help with ESM <--> CJS interoperability, see docs. We can revisit some NPM bumps after a Node upgrade.

Closes: https://github.com/balena-os/balena-supervisor/pull/2321, https://github.com/balena-os/balena-supervisor/pull/2320, https://github.com/balena-os/balena-supervisor/pull/2319, https://github.com/balena-os/balena-supervisor/pull/2315, https://github.com/balena-os/balena-supervisor/pull/2290

Page- commented 5 months ago

@cywang117 husky might be ESM but the supervisor doesn't import it anywhere, it's only used as essentially a binary

Page- commented 5 months ago

PRed the husky update in #2323

cywang117 commented 5 months ago

@balena-ci I self-certify!