search

balena-os / balena-supervisor

Balena Supervisor: balena's agent on devices.
https://balena.io
Other
148 stars 63 forks source link

Refactor host config module #2329

Closed cywang117 closed 3 months ago

cywang117 commented 5 months ago

This adds better data conversion between system-proxy configuration files redsocks.conf and no_proxy, an intermediate internal data type RedsocksConf, and a i/o data type HostConfiguration which the user interacts with via PATCH|GET /v1/device/host-config.

Change-type: minor

cywang117 commented 3 months ago

@pipex Thanks for your continued help with this code review. I think we're almost there! Here's my latest revision which addresses your comments where actionable. I've also removed any exports that are unnecessary in a separate commit, 16d8a59f9c185fcef1a08eab5fb6f156b4763d6b

pipex commented 3 months ago

Almost there, I think we should address these last two points before merging

cywang117 commented 3 months ago

@pipex Last two points addressed!