search

balena-os / balena-supervisor

Balena Supervisor: balena's agent on devices.
https://balena.io
Other
150 stars 63 forks source link

Remove custom typings for docker-delta #2350

Closed pipex closed 4 months ago

pipex commented 4 months ago

This are no longer needed since docker-delta migrated to typescript in v4 and the custom typings were actually masking some bugs

This PR fixes the issue where the supervisor would report 

Failed to download image 'registry2.balena-cloud.com/v2/120f8fdcef33853bcec70149ab283a55@sha256:a097a71c8ac1d38bab3f089c86adb0aa82d5906045a00117f1f54d1324b43609' due to 'Right-hand side of 'instanceof' is not an object'

If it fell into this catch block https://github.com/balena-os/balena-supervisor/blob/ae823fea181e2b1680940538b04b5af37c1b3229/src/lib/docker-utils.ts#L234-L242

Change-type: patch

pipex commented 4 months ago

This still requires a new version of docker-delta exporting OutOfSyncError

pipex commented 4 months ago

I self-certify!