Add takeover based HUP script

balena-os / balenahup

BALENA Host os UPdater

https://balena.io/

36 stars 11 forks source link

Add takeover based HUP script #407

Closed kb2ma closed 1 day ago

kb2ma commented 1 week ago

This script is equivalent to upgrade-2.x.sh, but for takeover based HUP. This script is derived from upgrade-2.x.sh, but removes unnecessary functionality. It also aims to be a model for a script implementation but avoiding gratuitous changes to the upgrade-2.x.sh original.

I am looking for higher level comments on the approach at this point. I have added some questions in the code. Don't mind the individual commits. I will squash them later.

github-advanced-security[bot] commented 1 week ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

kb2ma commented 2 days ago

@alexgg Fixed up from your review and rebased. All changes are in the final commit. In addition to your review, I did these things:

Renamed "takeover_path" to "work_dir". It's more descriptive, especially since adding the cleanup function
Added some options to the takeover binary to accommodate how it works now

If it looks OK, I'll squash down to a single commit for final approval.