Allow for configuring the internal storage

balena-os / leviathan-worker

The worker layer for Leviathan including worker plugins QemuKit & AutoKit

Apache License 2.0

6 stars 4 forks source link

Allow for configuring the internal storage #60

Closed alexgg closed 1 year ago

alexgg commented 1 year ago

What's the purpose of booting with only the external disk attached?

It's so that it uses the installer migration.

alexgg commented 1 year ago

Manual tests:

[x] Setting QEMU_INTERNAL_STORAGE as global environment variable allows to run the migrator tests on QEMU
[x] By default the behaviour is unchanged - both disks are present and the flasher is used
[x] Autokit/testbot devices skip the migrator test

alexgg commented 1 year ago

@rcooke-warwick I am still looking into this - the e2e tests still unpack the raw image as opposed to the meta-balena tests and I did not count with that.

jakogut commented 1 year ago

@rcooke-warwick I am still looking into this - the e2e tests still unpack the raw image as opposed to the meta-balena tests and I did not count with that.

@alexgg We should be able to remove the unwrapping from the e2e tests.

alexgg commented 1 year ago

false positive on aarch64 tests, requesting changes to block an auto merge to be sure there's nothing wrong

Will be addressed on https://github.com/balena-os/leviathan-worker/pull/62. There is also no way I could find to have the workflow fail/exit when just one step fails.