balena-os / leviathan-worker

The worker layer for Leviathan including worker plugins QemuKit & AutoKit
Apache License 2.0
6 stars 4 forks source link

enable serial terminal interaction #63

Closed rcooke-warwick closed 1 year ago

rcooke-warwick commented 1 year ago

PR to enable executeCommandInHostOs() in tests to use serial terminal as an option, instead of ssh

The main use cases were:

Notes on implementation:

Change-type: patch

klutchell commented 1 year ago

No objections from me. What is the main use case or benefit of adding this?

alexgg commented 1 year ago

@rcooke-warwick how is the caller to executeCommandInHostOs() choosing channel (ssh/serial)?

rcooke-warwick commented 1 year ago

sorry @alexgg @klutchell I had opened this PR the other week just to test flowzone out (it was during that point where alexes PR got caught in the required checks deadlock) it wasn't ready for a review

I hadn't looked at it since then, but will come back to it now. The main use cases were:

klutchell commented 1 year ago

Sounds good to me, if it's working for you!

rcooke-warwick commented 1 year ago

@balena-ci I self-certify!