search

balena-os / leviathan

A distributed hardware testing framework
https://balena-os.github.io/leviathan
Apache License 2.0
23 stars 6 forks source link

minor: Add Leviathan Test Helpers #976

Closed vipulgupta2048 closed 1 year ago

vipulgupta2048 commented 1 year ago

To reduce Core's dependencies and in the end, simplify Leviathan architecture. We are taking the first steps to use the leviathan test helpers package in the e2e test suite. This will aid in removing Core's helpers #977 and helps provide a testbed to stabilize changes made in the test-helpers package.

Signed-off-by: Vipul Gupta (@vipulgupta2048) vipulgupta2048@gmail.com

rcooke-warwick commented 1 year ago

this all looks good to me -

As far as I can see, there is no way for this to break anything other than leviathan e2e tests - which it won't as we can see those tests passing here. This is because you have not removed anything, in meta balena until the helpers are verified and that PR merges (https://github.com/balena-os/meta-balena/pull/3091) they will continue to use the "baked-in" functions

Maybe we can add a quic note to the PR description as to why we are making this change also

vipulgupta2048 commented 1 year ago

Added the quick note and I completely agree with the nonbreaking changes with this PR. PR #826 was similar in this regard.

vipulgupta2048 commented 1 year ago

@balena-ci I self-certify!