search

balena-os / meta-balena

A collection of Yocto layers used to build balenaOS images
https://www.balena.io/os
967 stars 115 forks source link

Pull a generic grub.cfg in meta-balena-common and use OS_KERNEL_CMDLINE #1728

Open ZubairLK opened 4 years ago

ZubairLK commented 4 years ago

Currently. grub is used by nuc,iot2000,qemu, some other devices. For some reason, the recipe/cfg file is in each integration layer. this should be in meta-balena-common. As the cfg diverges for changes. e.g. for rollbacks.

There should be one cfg via meta-balena-common. And BSP/integration layers should use OS_KERNEL_CMDLINE and bbappends if they want to tweak something.

balena-ci commented 4 years ago

[ffissore] This issue has attached support thread https://jel.ly.fish/#/support-thread~738a95f8-5504-49fc-b063-e05667e8e2e2

ZubairLK commented 4 years ago 
zubairlk@zubair-xps-resin:~/resin/yocto/balena-all-devices$ find . | grep grub.cfg
./balena-intel/layers/meta-balena-genericx86/recipes-bsp/grub/grub-conf/grub.cfg_external
./balena-intel/layers/meta-balena-genericx86/recipes-bsp/grub/grub-conf/grub.cfg_internal_template
./balena-stem-x86-32bit/layers/meta-balena-stem-x86-32bit/recipes-bsp/grub/files/grub.cfg_external
./balena-stem-x86-32bit/layers/meta-balena-stem-x86-32bit/recipes-bsp/grub/files/grub.cfg_internal-dev
./balena-stem-x86-32bit/layers/meta-balena-stem-x86-32bit/recipes-bsp/grub/files/grub.cfg_internal-prod
./balena-qemu/layers/meta-balena-qemu/recipes-bsp/grub/files/grub.cfg
./balena-iot2000/layers/meta-balena-iot2000/recipes-bsp/grub/files/grub.cfg_dev
./balena-iot2000/layers/meta-balena-iot2000/recipes-bsp/grub/files/grub.cfg_prod
./balena-up-board/layers/meta-balena-up-board/recipes-bsp/grub/files/grub.cfg_external
./balena-up-board/layers/meta-balena-up-board/recipes-bsp/grub/files/grub.cfg_internal-dev
./balena-up-board/layers/meta-balena-up-board/recipes-bsp/grub/files/grub.cfg_internal-prod
zubairlk@zubair-xps-resin:~/resin/yocto/balena-all-devices$