While the actual HUP works because of /sys being bindmounted by hostapp-update, rollbacks will fail to run the old OS hooks unless efivarfs is mounted.
Change-type: patch
Tested manually on the following configurations:
Seeed J4012
rollback-altboot from latest cloud image to PR - passed
rollback-health balena-engine from latest cloud image to PR - passed
rollback-health vpn from latest cloud image to PR - passed
rollback-health from PR to PR - passed
HUP from latest cloud image to PR - passed
Orin NX:
rollback-health from old cloud image to PR - passed
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
This fixes rollback-health failures for boards like the Jetson Seeeed J4012, which updates efivars for capsule updates from container hooks and not from the current OS hooks. This problem was spotted while running Autokit tests as per internal thread https://balena.zulipchat.com/#narrow/stream/403752-channel.2Fsupport-help/topic/Missing.20binder.20module.20in.20L4T.2FBalenaOS/near/419425908
While the actual HUP works because of /sys being bindmounted by hostapp-update, rollbacks will fail to run the old OS hooks unless efivarfs is mounted.
Change-type: patch
Tested manually on the following configurations:
Seeed J4012
Orin NX:
rollback-health from old cloud image to PR - passed
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines