a203bcdfd567c0cc4b4ed9de493513142cd7463f introduced a dependency on /usr/sbin/balena-config-defaults to hostapp-update-hooks, however during HUP the script is not only executed in the "new" OS container but directly in the context of the "old" OS as well, so /usr/sbin/balena-config-defaults needs to exist there. The file was introduced in balenaOS v2.99.28, so trying to HUP from anything before that will fail.
This patch changes this to a soft dependency so even if the file is missing HUP will continue.
'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)
a203bcdfd567c0cc4b4ed9de493513142cd7463f introduced a dependency on
/usr/sbin/balena-config-defaults
tohostapp-update-hooks
, however during HUP the script is not only executed in the "new" OS container but directly in the context of the "old" OS as well, so/usr/sbin/balena-config-defaults
needs to exist there. The file was introduced in balenaOS v2.99.28, so trying to HUP from anything before that will fail.This patch changes this to a soft dependency so even if the file is missing HUP will continue.
Contributor checklist
Change-type
present on at least one commitSigned-off-by
is presentReviewer Guidelines